Allow options to dynamically hide/unhide based on the value of other options

embeddedt / embeddium

An open-source client performance mod for Minecraft (based on Sodium 0.5.8) prioritizing reliability & mod compatibility

https://legacy.curseforge.com/minecraft/mc-mods/embeddium

GNU Lesser General Public License v3.0

161 stars 52 forks source link

Allow options to dynamically hide/unhide based on the value of other options #285

Open VOLKOUL opened 2 months ago

VOLKOUL commented 2 months ago

Bug Description

If you disable Nvidium in the settings, then quit the game and launch it again Nvidium will be reenabled. Also, when disabling Nvidium, Nvidium's options won't automatically gray out (showing that they can't be changed). For them to appear grayed out, you have to exit and reenter the settings. This was not a problem in prior versions. I also had TexTrue's Embeddium Options installed back then.

embeddedt commented 2 months ago

The first part of the issue is intended behavior according to Nvidium's code.

VOLKOUL commented 2 months ago

Oh, ok! Apologies :D

Nolij commented 1 month ago

Just tested using Embeddium 0.3.14 with and without RSO. It behaves the exact same as the latest 0.3.18 dev build. This can still be considered a bug, but it is not a regression (translation: it didn't work before, and now it's broken; it's always been broken).

embeddedt commented 1 month ago

We haven't yet implemented the ability for option screens to dynamically hide and show options based on the value of other options (and Sodium never had it), so this is a feature request. We do intend to implement this at some point but we have to figure out how to do it cleanly first.