embeddings-benchmark / mteb

MTEB: Massive Text Embedding Benchmark
https://arxiv.org/abs/2210.07316
Apache License 2.0
1.83k stars 246 forks source link

install only ruff for lint workflow #1001

Closed Samoed closed 3 months ago

Samoed commented 3 months ago

Install only ruff for lint workflow instead of all main dependencies.

KennethEnevoldsen commented 3 months ago

This will speed up linting slightly. However, it does lead to multiple places of specifying installation. make install simplifies the installation process - as it is set up now any changes to linting commands happen in the make file. E.g. we could replace ruff in make lint-check without having to worry about changing the CI at all.

I am not sure this change is worth it.