search

embench / embench-iot

The main Embench repository
https://www.embench.org/
GNU General Public License v3.0
254 stars 104 forks source link

Remove debug printfs from benchmarks #152

Open mtdudek opened 2 years ago

mtdudek commented 2 years ago

This commit removes printfs from md5sum test, as they can influence test results. Signed-off-by: Maciej Dudek mdudek@antmicro.com

jeremybennett commented 2 years ago

@mtdudek Thanks for picking this up. There should be no external library calls in the benchmark.

I'd rather just remove this code. The danger with #define is that users will define them on the command line and we'll get invalid results. Are you happy to make this change?

Added @PaoloS02 as a second reviewer.

mtdudek commented 2 years ago

I've removed printfs from benchmarks' bodies.