Open fanghuaqi opened 2 years ago
Found this error below is caused by https://github.com/embench/embench-iot/blob/master/pylib/embench_core.py#L266, can be fixed by
File "/home/hqfang/workspace/software/embench-iot/pylib/embench_core.py", line 266, in output_stats
log.info(' }{oc}'.format(oc=opt_comma))
ValueError: Single '}' encountered in format string
- log.info(' }{oc}'.format(oc=opt_comma))
+ log.info(' }}{oc}'.format(oc=opt_comma))
Hi there,
When I tried to print json output of size information, and found this strange logic here https://github.com/embench/embench-iot/blob/master/benchmark_size.py#L158-L168
This will cause the following error when I run
./benchmark_size.py --json-output
:And I debug into it, found this
json_comma
is false, and but according to the code, it should be true. So I changeddest='json_comma'
todest='json_comma2'
, and found evaluate theargs
, and found there will be two values as below(json_comma=False, json_comma2=True), it seems the argparse package default convert the--json-comma
argument tojson_comma
:So could we just keep one argument
--no-json-comma
and remove the unused--json-comma
Thanks