search

ember-a11y / ember-a11y-testing

A suite of accessibility tests that can be run within the Ember testing framework
MIT License
137 stars 49 forks source link

Test error after upgrading `@ember/test-helpers` to 2.9.0 #489

Closed eleenyeh closed 1 year ago

eleenyeh commented 1 year ago

Hello!

I'm starting to see this error consistently in integration tests after upgrading @ember/test-helpers to 2.9.0:

Assertion Failed: currentRouteName shoudl be a string

Looks like the new version adds an assert on the currentRouteName helper which is used by middleware-reporter. I think we should avoid calling currentRouteName outside of acceptance tests. Let me know what you think! Thanks :)

drewlee commented 1 year ago

PR #491 addresses the issue.

drewlee commented 1 year ago

Fix has been merged and will be followed up with a release.