search

ember-a11y / ember-a11y-testing

A suite of accessibility tests that can be run within the Ember testing framework
MIT License
137 stars 50 forks source link

Upgrade @ember/test-helpers to 3.x #509

Closed fivetanley closed 1 year ago

fivetanley commented 1 year ago

depends upon https://github.com/ember-a11y/ember-a11y-testing/pull/508

partially resolves #506

MelSumner commented 1 year ago

I think there might be some changes to make related to what was merged in https://github.com/ember-a11y/ember-a11y-testing/pull/503

fivetanley commented 1 year ago

It looks like this is blocked on ember-qunit: https://github.com/ember-a11y/ember-a11y-testing/actions/runs/5214440386/jobs/9410705701?pr=509#step:6:125

We'll need https://github.com/emberjs/ember-qunit/pull/1077 and a new release of ember-qunit first (as @MelSumner pointed out in a slack conversation with me at work).

I think there might be some changes to make related to what was merged in https://github.com/ember-a11y/ember-a11y-testing/pull/503

It looks like the first time I made the commit I used a newer yarn which significantly changed the lock file. I reverted back to the version in package.json -> volta -> yarn and I think we're where we need to be before upgrading ember-qunit.

MelSumner commented 1 year ago

The README should be updated as part of this PR to tell users what version of the addon to use if they need to support Node 14.

MelSumner commented 1 year ago

I'm going to try a pre-release for this so we can see how it works