ember-addons / bootstrap-for-ember

Bootstrap for Ember.js
http://ember-addons.github.io/bootstrap-for-ember
Apache License 2.0
703 stars 103 forks source link

Do not set btn-group class when vertical=true #181

Closed simonihmig closed 8 years ago

simonihmig commented 10 years ago

When setting vertical=true, the button group component should have only a "btn-group-vertical" class, not combined with "btn-group" as it is now, see http://getbootstrap.com/components/#btn-groups. When btn-group is also set, there is a slight CSS glitch: the upper right border is not rounded! This comes from a CSS selector triggered by the btn-group class, which should not be applied to a vertical button group.

This is also visible on the demo page, see screenshot attached! image

duereg commented 10 years ago

Any movement on this?