search

ember-animation / ember-animated

Core animation primitives for Ember.
https://ember-animation.github.io/ember-animated/
MIT License
244 stars 90 forks source link

Interested in TypeScript? #172

Closed simply-alliv closed 4 days ago

simply-alliv commented 5 years ago

Hello! I use your addon and really appreciate it. I’m also participating in this quest issue to add TypeScript support throughout the Ember.js ecosystem. This will benefit to everyone who uses your addon, not just TypeScript users! (See here for an explanation.)

Are you interested in either converting the addon to use TypeScript itself, or in a in adding type definitions? I’d love to help out, if so! And if not, that’s just fine. Thanks!

nickschot commented 5 years ago

@AlliVil some more info in here: https://github.com/ember-animation/ember-animated/issues/89 doesn't seem much has happened in that area. The branch is still there though.

simply-alliv commented 5 years ago

I see, I'll contribute on that branch.

simply-alliv commented 5 years ago

Should I just add type declaration files or convert JavaScript files to TypeScript files?

simply-alliv commented 5 years ago

The branch seems to be really old with many outdated/deprecated dependencies. Would it not be better to start a new branch?

ef4 commented 5 years ago

Would it not be better to start a new branch?

Whichever you prefer.

Should I just add type declaration files or convert JavaScript files to TypeScript files?

Convert to typescript. I am opposed to maintaining separate d.ts files because it's so error prone.

HeroicEric commented 4 days ago

I think this can be closed now since https://github.com/ember-animation/ember-animated/pull/430 converted to typescript