search

ember-animation / ember-animated

Core animation primitives for Ember.
https://ember-animation.github.io/ember-animated/
MIT License
244 stars 90 forks source link

Feature: Show Octanified examples in the docs #183

Open jenweber opened 4 years ago

jenweber commented 4 years ago

Right now, the docs show classic Ember. I think there should be both classic and Octane examples, at least in a few places.

ef4 commented 4 years ago

If you mean angle brackets, there's a deliberate reason I don't use them for the control-flow-like components.

<AnimatedContainer /> and <AnimatedOrphans /> emit real DOM and the intention is to always show them that way, with angle brackets.

But I want people to think of {{#animated-if} the same way they think of {{#if}}, and {{#animated-each}} the same as {{#each}}. For these, using angle bracket syntax makes them weirder, because they're trying to be "control-flow", more than components.

See also https://github.com/tildeio/ember-control-flow-component, which will let us port them to be Glimmer components underneath while still keeping this syntax.

jenweber commented 4 years ago

I was thinking of showing native classes for the JS examples, and using scoped arguments in templates. I see that it makes sense to keep the curlies/angle brackets as-is.