ember-animation / ember-animated

Core animation primitives for Ember.
https://ember-animation.github.io/ember-animated/
MIT License
244 stars 90 forks source link

v1.1.3 is missing type declarations #681

Closed dfreeman closed 8 months ago

dfreeman commented 8 months ago

The last 1.x release, v1.1.3, seems to be missing its type declarations. This is causing ember-try scenarios, which always ignore the lockfile, to fail for our projects with an ember-animated@^1 dependency unless we lock to <= 1.1.2

For instance:

SergeAstapov commented 8 months ago

appears pnpm exec glint --declaration was not working at a time of publishing.

Checked out v1.1.3 tag and appears pnpm exec glint --declaration does not create declarations folder and I missed that at a time of publishing.

Trying to figure out the reason for this

SergeAstapov commented 8 months ago

looks like I facing the same issue as https://github.com/typed-ember/glint/issues/599

SergeAstapov commented 8 months ago

published as v1.1.4.

Thank you for pointing this out @dfreeman!

dfreeman commented 8 months ago

Thank you!