ember-animation / ember-animated

Core animation primitives for Ember.
https://ember-animation.github.io/ember-animated/
MIT License
245 stars 90 forks source link

App broken after upgrade from 2.0.0 to 2.0.1 #695

Open villander opened 8 months ago

villander commented 8 months ago

Description of the bug: When I bump the library and run ember s I see this issue

image

My component:

import move from 'ember-animated/motions/move';
import { fadeOut } from 'ember-animated/motions/opacity';
import type Sprite from 'ember-animated/-private/sprite';

export default class NotesNoteBoard extends Component<NotesNoteBoardComponentSignature> {
.....
// eslint-disable-next-line require-yield
  *transition({
    keptSprites,
    removedSprites,
  }: {
    keptSprites: Sprite[];
    removedSprites: Sprite[];
  }) {
    for (const sprite of keptSprites) {
      move(sprite);
    }

    for (const sprite of removedSprites) {
      fadeOut(sprite);
    }
  }
 }

cc @SergeAstapov

SergeAstapov commented 7 months ago

@villander if you could create minimal reproduction, it would be helpful to figure out the root cause and if it's related to ember-animated addon or something else