search

ember-animation / liquid-fire

Animations & transitions for ambitious Ember applications.
Other
1.15k stars 199 forks source link

Produce prebuilt releases compatible with each Ember version #170

Open galfert opened 9 years ago

galfert commented 9 years ago

When using the prebuilt release version 0.16.1 in an app based on Ember App Kit, I see the following error:

Uncaught Error: Unknown template object: function               handlebars.js:455
 template                                                       handlebars.js:455
 hb.template                                                    handlebars.js:644
 (anonymous function)                                  liquid-fire-0.16.1.js:1858
 requireModule                                           liquid-fire-0.16.1.js:71
 __exports__.initialize                                liquid-fire-0.16.1.js:2488
 window.Ember.Application.initializer.initialize       liquid-fire-0.16.1.js:2550
 (anonymous function)                                               ember.js:3079
 Visit                                                              ember.js:2002
 DAG.topsort                                                        ember.js:2114
 Namespace.extend.runInitializers                                   ember.js:3076
 Namespace.extend._initialize                                       ember.js:2961
 Backburner.run                                                      ember.js:194
 run                                                               ember.js:17905
 runInitialize                                                      ember.js:2758
 jQuery.Callbacks.fire                                             jquery.js:3143
 jQuery.Callbacks.self.fireWith                                    jquery.js:3255
 jQuery.extend.ready                                               jquery.js:3467
 completed                                                         jquery.js:3498

We are using Ember 1.9.1 and Handlebars 2.0.

Are there any known issues when using Handlebars 2.0? I couldn't find anything in the open or closed issues.

ef4 commented 9 years ago

Unfortunately, we can't do a single prebuilt version anymore that will work with any Ember version, because you need to choose the right template compiler to go with your Ember & Handlebars.

To make this work, we would need to produce separate builds for each Ember release. I'm happy to take a PR that achieves that, and I may eventually find time to do it myself, but I can't prioritize it right this moment.