search

ember-animation / liquid-fire

Animations & transitions for ambitious Ember applications.
Other
1.15k stars 200 forks source link

multiple modals #179

Open samselikoff opened 9 years ago

samselikoff commented 9 years ago

Here's my router:

this.modal('modals/question-detail', {
  withParams: [{selectedQuestion: 'question'}],
  actions: {requestDelete: 'willDeleteQuestion'}
});
this.modal('modals/delete-question', {
  withParams: 'willDeleteQuestion',
  otherParams: {
    selectedQuestion: 'question'
  }
});

Clicking a delete button in the question-detail modal triggers an action in controller, which sets willDeleteQuestion to true. If I do this, the second delete-question modal properly gets rendered, but the .lf-modal-open class gets removed from <body>, so the rest of the page scrolls.

Known issue? Should I investigate + write a failing test?

ef4 commented 9 years ago

Not a known issue, the .lf-modal-open class should stay on <body> any time a modal is on screen. A test would be great.