Closed spencer516 closed 4 years ago
Thanks for the bug report, can you please share the output of npm ls
? I am guessing this can happen if you have both a direct dependency on liquid-fire and an indirect dependency through another addon.
Certainly. I suppose I also left out that this is an addon that we're using as an Engine — and this emerged after making it into one. (Though, I also did a bunch of npm upgrades in the middle of that too).
I think I might be having a similar issue, also using LF in an engine.
The Broccoli Plugin: [SimpleConcat: Concat: Vendor /assets/engine-vendor.css] failed with:
Error: ENOENT: no such file or directory, stat '/Users/iradchenko/workspace/wflhd/tmp/simple_concat-input_base_path-343Zm5MN.tmp/0/vendor/liquid-fire.css'
at Error (native)
at Object.fs.statSync (fs.js:987:18)
at Concat.keyForFile (/Users/iradchenko/workspace/wflhd/node_modules/ember-engines/node_modules/broccoli-caching-writer/index.js:87:20)
at Array.map (native)
at Concat.CachingWriter._conditionalBuild (/Users/iradchenko/workspace/wflhd/node_modules/ember-engines/node_modules/broccoli-caching-writer/index.js:109:65)
at /Users/iradchenko/workspace/wflhd/node_modules/broccoli-plugin/read_compat.js:61:34
at tryCatch (/Users/iradchenko/workspace/wflhd/node_modules/rsvp/dist/rsvp.js:538:12)
at invokeCallback (/Users/iradchenko/workspace/wflhd/node_modules/rsvp/dist/rsvp.js:553:13)
at publish (/Users/iradchenko/workspace/wflhd/node_modules/rsvp/dist/rsvp.js:521:7)
at flush (/Users/iradchenko/workspace/wflhd/node_modules/rsvp/dist/rsvp.js:2373:5)
The broccoli plugin was instantiated at:
at Concat.Plugin (/Users/iradchenko/workspace/wflhd/node_modules/broccoli-plugin/index.js:7:31)
at Concat.CachingWriter [as constructor] (/Users/iradchenko/workspace/wflhd/node_modules/ember-engines/node_modules/broccoli-caching-writer/index.js:18:10)
at new Concat (/Users/iradchenko/workspace/wflhd/node_modules/ember-engines/node_modules/broccoli-concat/concat.js:33:17)
at module.exports (/Users/iradchenko/workspace/wflhd/node_modules/ember-engines/node_modules/broccoli-concat/index.js:26:10)
at CoreObject.buildVendorCSSWithImports (/Users/iradchenko/workspace/wflhd/node_modules/ember-engines/lib/engine-addon.js:171:7)
at CoreObject.treeForPublic (/Users/iradchenko/workspace/wflhd/node_modules/ember-engines/lib/engine-addon.js:454:61)
at CoreObject._treeFor (/Users/iradchenko/workspace/wflhd/node_modules/ember-cli/lib/models/addon.js:371:33)
at CoreObject.treeFor (/Users/iradchenko/workspace/wflhd/node_modules/ember-engines/lib/engine-addon.js:649:23)
at /Users/iradchenko/workspace/wflhd/node_modules/ember-cli/lib/broccoli/ember-app.js:498:20
at Array.map (native)
I'm seeing this issue too with engines, and the same fix @spencer516 provided temporarily fixes the issue.
I think this is fixed in 0.26.5, please give it a try.
@spencer516 , @knownasilya : Did 0.26.5 fix your problem? Can this issue be closed?
@winne42 — I sincerely have no clue!. Haven't used Liquid Fire in a few years.
I'm going to guess we're okay...I'll close the issue.
I'm not sure wether this is a Liquid Fire or an Ember-cli issue — so sorry for that in advance.
The short of it: my animations, which are in an addon, stopped working once I upgraded to any version after 0.26.1.
Error is:
undefined is not an object (evaluating '_velocity["default"].defaults[key] = props[key]')
Digging into it, it looks like my app doesn't have Velocity at all (
$.Velocity
andEmber.$.Velocity
are both undefined). The fallback of an empty function defined in the velocity shim file is used instead.If I remove the
else if (haveShimAMDSupport(app))
block from Liquid Fire'sindex.js
, the issue goes away. I added some logs and it looks like theincluded
hook fires twice: once where the app does have anamdModulesName
key and once where it does not. My knowledge of Ember-CLI's internals aren't deep enough to know the context of why it's twice and why the app in each case is something else entirely — but, I can only guess it has something to do with this being an addon and, possibly, my recent upgrade to Ember-cli 2.9.1.Happy to help troubleshoot or provide any more details as needed. Thanks!