search

ember-animation / liquid-fire

Animations & transitions for ambitious Ember applications.
Other
1.15k stars 199 forks source link

ember-getowner-polyfill.import deprecation #534

Open tamzinblake opened 7 years ago

tamzinblake commented 7 years ago

I believe this starts happening after Ember 2.9 (can't find the actual deprecation link)

ember-getowner-polyfill is now a true polyfill. Use Ember.getOwner directly instead of importing from ember-getowner-polyfill [deprecation id: ember-getowner-polyfill.import]

ef4 commented 7 years ago

Are you on liquid-fire 0.27.0? It should have addressed this deprecation warning.

tamzinblake commented 7 years ago

Yes, this is after upgrading. I'll take a look at where this is happening.

craigsketchley commented 7 years ago

I got this issue too. It seems to occur after https://github.com/rwjblue/ember-getowner-polyfill was updated (v1.0.1 works for me, but v1.1.x does not).

msalahz commented 7 years ago

I get the same , what is the status of this ?

Vinchens00-zz commented 7 years ago

Hi guys, I ran into the same issue. Do you have any updates here?

ef4 commented 7 years ago

There is a bugfix in 0.27.1, does it fix this use case?

Vinchens00-zz commented 7 years ago

It doesn't for me.

serv commented 7 years ago

Still happening on Ember 2.12.1

msalahz commented 7 years ago

Hi, I tracked the source of this warring in my app and I found two addons that coz it.

  1. ember-simple-auth, upgrading to last release fixed it.
  2. ember-gestures, still using it to support ember versions < 2.3