search

ember-animation / liquid-fire

Animations & transitions for ambitious Ember applications.
Other
1.15k stars 199 forks source link

Fix ember version detection #561

Closed akatov closed 7 years ago

akatov commented 7 years ago

a rebased version of #556 with passing tests. fixes #556

akatov commented 7 years ago

@ivanvanderbyl I hope you're ok with me using your work here :-)

ivanvanderbyl commented 7 years ago

@akatov looks good to me, let's get this fixed :)

ef4 commented 7 years ago

Thanks!

ef4 commented 7 years ago

I was dreading spending another hour figuring out why Travis wasn't passing, nice to see it all turn green with this merged. 💯

akatov commented 7 years ago

🎊 🎊 🎊