search

ember-animation / liquid-fire

Animations & transitions for ambitious Ember applications.
Other
1.15k stars 199 forks source link

Including Velocity.js as an Ember-CLI addon #59

Open taras opened 10 years ago

taras commented 10 years ago

Hi Edward,

I just released ember-velocity-mixin. It's an Ember-CLI addon. It imports Velocity.js 1.0. My mixin can be used together with your library, but if used together, they'll both include Velocity.

I'm thinking about creating an Ember-CLI Addon that will provide Velocity.js. It can be used as a dependency by both of our libraries.

Would you be open to a PR that would make your library use this new addon as a dependency?

Taras

ef4 commented 10 years ago

Sure, that's fine with me. But please make it load velocity from npm like liquid-fire does, rather than loading it from bower like ember-velocity-mixin does.

npm offers important deployment guarantees (npm-shrinkwrap) that bower doesn't, so I find it preferable whenever a package is available in both places.

miguelcobain commented 10 years ago

:+1: for this.

Just changing the dependency in package.json wouldn't be enough, i guess?

runspired commented 8 years ago

This PR is now possible, ember-cli-velocity can be consumed as an addon by another addon.