search

ember-animation / liquid-fire

Animations & transitions for ambitious Ember applications.
Other
1.15k stars 199 forks source link

Is JQuery needed? #633

Closed devotox closed 5 years ago

devotox commented 5 years ago

With Ember 3.X Jquery has been deprecated and removed. Is there a path to take to remove all Jquery usage?

ef4 commented 5 years ago

There is a path. My intention is to make liquid-fire depend on ember-animated, and ember-animated has been designed to not need jQuery.

But this is going to be a breaking change, because we currently expose jQuery in the public API for how transitions get defined.

ef4 commented 5 years ago

I should also clarify, jQuery is not deprecated in Ember 3.x. There's no plan to stop supporting it.

The only thing that's deprecated is having jQuery magically added to your app. Now you'll need to explicitly ask for it.

devotox commented 5 years ago

@ef4 yup totally correct that is what I meant not deprecated but too lazy to right out the full sentence. Typical developer ay?

When you do have a set of plans for how you are going to move forward moving over to ember-animated and you would love to break up the work. I would gladly take some on