search

ember-animation / liquid-fire

Animations & transitions for ambitious Ember applications.
Other
1.15k stars 199 forks source link

Hopefully Easy jQuery Fixes #635

Closed jherdman closed 5 years ago

jherdman commented 5 years ago

Instead of accessing a Component's this.$() property, which is deprecated in modern Ember, we manually wrap this.element. I've taken care of a cases of jQuery usage that were easy to fix, but most have been left alone to mitigate the chances of a regression.

jherdman commented 5 years ago

I'm having a bit of trouble running tests locally. I'm seeing these errors:

liquid-fire [hopefully-easy-jquery-fixes] % yarn test
yarn run v1.15.2
$ eslint . && ember test

/Users/james/Projects/liquid-fire/version-specific-1.13/index.js
  1:1  error  Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

/Users/james/Projects/liquid-fire/version-specific-2.9/index.js
  1:1  error  Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

✖ 2 problems (2 errors, 0 warnings)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
jherdman commented 5 years ago

This doesn't handle the vendor shim. I'm not really familiar with what's going on in there so I've left it alone.

ef4 commented 5 years ago

Thanks. I will take a look at also fixing the vendor shim.