search

ember-best-practices / memory-leak-examples

Examples of memory leaks and common patterns that cause them
224 stars 16 forks source link

"Memory" is seen and not "Profiles" #16

Open shearichard opened 6 years ago

shearichard commented 6 years ago

In exercise-1.md reference is made to the "Profiles" tab in the text and an accompanying screenshot.

When I went to do the exercise I couldn't find that tab and it took me a little while to realise what was wrong.

I have looked at devtools in Win64/Chrome; Win64/Canary and Linux/Chrome and in each case the tab in question is called "Memory" not "Profiles".

The version I've looked at for Win64/Chrome; Win64/Canary and Linux/Chrome are 65, 67 and 65 respectively,

I would be happy to do a PR for this but I'm concerned that perhaps on a Mac that table is still called "Profiles".

Could someone check that as I don't have access to a Mac.

shearichard commented 6 years ago

Update

Just reading the Chrome Dev Tools manual pages for other reasons and came across this:

Note: In Chrome 58 the Profiles panel was renamed to the Memory panel.

So it does seem to be all platforms have that change of terminology .

trentmwillis commented 6 years ago

Would you be open to submitting a PR to update the guides?

shearichard commented 6 years ago

Sorry for slow response . I'm happy to look at this but there is one issue .

I have access to Windows and Linux. The screen shots currently in use in exercise-1.md come, I think , from a Mac so my screen shots would be inconsistent ? Does that matter ?