search

ember-cli-deploy / ember-cli-deploy-revision-data

An ember-cli-plugin to create a unique revision key for the build
MIT License
22 stars 57 forks source link

Feature: Ability to configure length of git revision key #22

Closed Bockit closed 3 years ago

Bockit commented 9 years ago

It would be nice if we could set the length, or even just a toggle for the whole thing.

jrowlingson commented 9 years ago

Ah, yes, I like this suggestion. I should be able to get to it tomorrow.

Bockit commented 9 years ago

That would be great, thanks

viniciussbs commented 6 years ago

I'm trying to use a Rollbar addon to track errors and an Ember CLI Deploy plugging to send the source maps to Rollbar. The problem is that the Rollbar addon uses version + the first 7 chars of the commit hash and this plugging uses version + the first 8 chars of the commit hash.

Reading the README, I saw that this plugging actually uses 2 different hash lengths according to the generator. Git Commit generator uses 7 chars and Version Commit generator uses 8 chars.

So, turning this configurable is a feature, but should we treat this inconsistency a bug - and, in this case, open a new issue for it?