search

ember-cli-deploy / ember-cli-deploy-revision-data

An ember-cli-plugin to create a unique revision key for the build
MIT License
22 stars 57 forks source link

add scm-data-generators and git scm generator #29

Closed ghedamat closed 8 years ago

ghedamat commented 8 years ago

first step in tackling https://github.com/ember-cli/ember-cli-deploy/issues/305

see https://github.com/ember-cli-deploy/ember-cli-deploy-redis/pull/56 https://github.com/ember-cli-deploy/ember-cli-deploy-display-revisions/pull/8

this assumes that we're ok in keeping the approach were we "hardcode" the possible "providers" into this plugin.

TODOs:

lukemelia commented 8 years ago

I wonder if "data collector" would be a better name than "data generator"

lukemelia commented 8 years ago

Looks good :+1:

ghedamat commented 8 years ago

@lukemelia updated

lukemelia commented 8 years ago

LGTM @ghedamat. What's up with the circleci build? And why do we have both travis and circle on this repo?

ghedamat commented 8 years ago

@lukemelia fixed the circle thingy by removing it now that we use travis and added tag support to scm generator

lukemelia commented 8 years ago

:+1: Great work @ghedamat!