search

ember-cli-deploy / ember-cli-deploy-revision-data

An ember-cli-plugin to create a unique revision key for the build
MIT License
21 stars 58 forks source link

Getting git-commit to work again with CircleCI #36

Closed nathanpalmer closed 8 years ago

nathanpalmer commented 8 years ago

We used to deploy directly from CircleCI and at one point a few months back it stopped working. I'm just now getting a chance to dig into it and attached is a fix that works for us.

I read up on the existing issues such as #33 which handles gracefully downgrading when revision info isn't available. However, I SSH'd into the CircleCI instance and revision information is definitely available. I put together this quick script to verify.

var gitRepoInfo = require('git-repo-info');
var path = gitRepoInfo._findRepo();
var info = gitRepoInfo(path);

console.log(info);

Running that on the instance worked just fine and I received the sha. The only difference seemed to be the version of git-repo-info used by ember-cli-deploy-revision-data versus what I used when I ran that script. This pull request simply upgrades the dependency which we've tested against our deploy and it's working great.

ghedamat commented 8 years ago

thanks @nathanpalmer