search

ember-cli-deploy / ember-cli-deploy-revision-data

An ember-cli-plugin to create a unique revision key for the build
MIT License
22 stars 57 forks source link

`git-commit` type fails with package `git-repo-info` version 1.3.0 #39

Closed mblayman closed 8 years ago

mblayman commented 8 years ago

The findRepo method in version 1.3.0 of git-repo-info no longer returns a string path for the repository path. It now returns an object literal with two values. This causes a path join to raise an exception.

- creating revision data using `git-commit`
|
+- didFail
TypeError: Path must be a string. Received { worktreeGitDir: '/srv/myapp/.git',
  commonGitDir: '/srv/myapp/.git' }
TypeError: Path must be a string. Received { worktreeGitDir: '/srv/myapp/.git',
  commonGitDir: '/srv/myapp/.git' }
    at assertPath (path.js:7:11)
    at Object.join (path.js:1211:7)
    at findRepo (/srv/myapp/client/node_modules/git-repo-info/index.js:43:20)
    at module.exports (/srv/myapp/client/node_modules/git-repo-info/index.js:144:21)
    at CoreObject.generate (/srv/myapp/client/node_modules/ember-cli-deploy-revision-data/lib/data-generators/git-commit.js:13:16)
    at Class._getData (/srv/myapp/client/node_modules/ember-cli-deploy-revision-data/index.js:59:12)
    at Class.prepare (/srv/myapp/client/node_modules/ember-cli-deploy-revision-data/index.js:36:24)
    at Object.fn (/srv/myapp/client/node_modules/ember-cli-deploy/lib/tasks/pipeline.js:159:21)
    at Pipeline._notifyPipelinePluginHookExecution (/srv/myapp/client/node_modules/ember-cli-deploy/lib/models/pipeline.js:175:19)
|
Pipeline aborted
lukemelia commented 8 years ago

Work in progress to fix this here: https://github.com/ember-cli-deploy/ember-cli-deploy-revision-data/pull/40

lukemelia commented 8 years ago

We would accept a PR to lock the dependency to a working version while this fix is in progress.

lukemelia commented 8 years ago

Fixed in v0.3.2