search

ember-cli-deploy / ember-cli-deploy-revision-data

An ember-cli-plugin to create a unique revision key for the build
MIT License
22 stars 57 forks source link

pin simple-git to version 1.57.0 as fails with 1.59.0 #44

Closed josephroffey closed 8 years ago

josephroffey commented 8 years ago

What Changed & Why

Reference simple-git 1.57.0 instead of ^1.47.0 as deploy fails with simple-git 1.59.0

Related issues

https://github.com/ember-cli-deploy/ember-cli-deploy-revision-data/issues/43 https://github.com/ember-cli-deploy/ember-cli-deploy/issues/432

MarkMT commented 8 years ago

This may not be the right fix. The exception happens in simple-git, but it seems that it may be because an incorrect path value is passed to it from the ScmDataGenerator. See https://github.com/ember-cli-deploy/ember-cli-deploy-revision-data/issues/43#issuecomment-257374206

lukemelia commented 8 years ago

Closing in favor of #45