ember-cli-deploy / ember-cli-deploy-revision-data

An ember-cli-plugin to create a unique revision key for the build

MIT License

21 stars 58 forks source link

Pass path string to SCM instead of object #45

Closed kpfefferle closed 7 years ago

kpfefferle commented 7 years ago

What Changed & Why

This passes the distDir string into ScmDataGenerator init instead of an object. This resolves the bug noted in #43 with a permanent fix (rather than the temporary fix suggested by #44).

Related issues

43

People

@ludalex @MarkMT @josephroffey

blimmer commented 7 years ago

I can confirm that this fixes my issue, too.

blimmer commented 7 years ago

can someone hotfix? cc @lukemelia

lukemelia commented 7 years ago

@blimmer @kpfefferle Released as 0.3.2. Thanks, folks!

blimmer commented 7 years ago

thanks!

ghedamat commented 7 years ago

Thanks @kpfefferle, I guess I was sloppy with my original implementation, sorry for the trouble!

ludalex commented 7 years ago

Thanks.