search

ember-cli-deploy / ember-cli-deploy-revision-data

An ember-cli-plugin to create a unique revision key for the build
MIT License
21 stars 58 forks source link

Fix simple-git version to 1.57.0 #48

Closed rsullivan00 closed 7 years ago

rsullivan00 commented 7 years ago

What Changed & Why

Lock down the simple-git version to 1.57.0 to fix a deployment issue that appears when the latest version (1.64.0) is used.

Related issues

Closes https://github.com/ember-cli-deploy/ember-cli-deploy-revision-data/issues/47

PR Checklist

People

lukemelia commented 7 years ago

Thanks @Rsullivan00. Is it possible to get test coverage associated with this change? Without it, it will be hard to know if/when it is safe to update this.

rsullivan00 commented 7 years ago

Hey @lukemelia, I'm not sure why/how the newest simple-git breaks with how we're using it, so I don't know how to add an appropriate test.

rsullivan00 commented 7 years ago

With simple-git@1.65.0 and a couple of small changes to other ember-deploy package versions, we are now able to deploy.

Since I'm not actually sure which project's dependencies are at fault, I'm going to close this issue.

For those wondering, I changed to versions

    "ember-cli-deploy-revision-data": "0.3.2",
    "ember-cli-deploy-s3": "0.4.0",
lukemelia commented 7 years ago

Thanks for following up @Rsullivan00. Glad to hear you got everything sorted out.