Allow configuration of the separator character (`+`) in git-tag-commit and version-commit

ember-cli-deploy / ember-cli-deploy-revision-data

An ember-cli-plugin to create a unique revision key for the build

MIT License

22 stars 57 forks source link

Allow configuration of the separator character (`+`) in git-tag-commit and version-commit #54

Closed reidab closed 7 years ago

reidab commented 7 years ago

What Changed & Why

This allows for the + symbol in the git-tag-commit and version-commit strategies to be configured by the user.

Why? The error reporting service I'm using at work (Sentry) recently changed the validation for what they consider valid release identifiers and the new format disallows +.

PR Checklist

[x] Add tests
[x] Add documentation
[ ] Prefix documentation-only commits with [DOC]

lukemelia commented 7 years ago

Thanks @reidab!

urbany commented 7 years ago

Can you release this @lukemelia ? It's breaking my builds because of a Sentry update.