search

ember-cli-deploy / ember-cli-deploy-revision-data

An ember-cli-plugin to create a unique revision key for the build
MIT License
22 stars 57 forks source link

Allow to specify revision key through ENV #60

Closed krasnoukhov closed 7 years ago

krasnoukhov commented 7 years ago

What Changed & Why

We use external deployment system (capistrano), which creates a release with git archive, so SCM data is not available. However, it provides revision identifier which can be passed to ember deploy. I'd say it would be useful to be able to just pass revision key through ENV in general. I'm wiling to add tests/documentation if this is seen as useful change. Thanks

PR Checklist

lukemelia commented 7 years ago

@krasnoukhov Are you aware that you don't necessarily need a plugin at all to do this. You would instead configure your other plugins which rely on the revisionKey to get it from the ENV var. If you'd like a hand, let us know in the ember community slack #ec-deploy channel

krasnoukhov commented 7 years ago

@lukemelia Yeah thanks you're totally right, I just completely missed that fact, sorry. So basically for "lightning strategy" I can just use something like this in config/deploy.js:

ENV.pipeline.disabled = { 'revision-data': true };
ENV.redis.revisionKey = process.env.REVISION_KEY;
lukemelia commented 7 years ago

@krasnoukhov yes, exactly! 👍