Change git-tag-commit data generator to use most recent ancestor tag

ember-cli-deploy / ember-cli-deploy-revision-data

An ember-cli-plugin to create a unique revision key for the build

MIT License

21 stars 58 forks source link

Change git-tag-commit data generator to use most recent ancestor tag #66

Closed courajs closed 2 years ago

courajs commented 6 years ago

What Changed & Why

Upgraded git-repo-info in order to take advantage of the lastTag feature. This allows deploying releases using the git-tag-commit generator without creating new a git tag. This is useful for pushing to staging before graduating a release to a full version bump.

Related issues

lastTag added to git-repo-info in https://github.com/rwjblue/git-repo-info/pull/37, released in v2.0.0 Closes #27 Closes #28 Closes #50

PR Checklist

[x] Add tests
[x] Add documentation (this was the behavior implied by the current documentation)

People

@reidab, @lukemelia, @jrowlingson,

courajs commented 6 years ago

Ping @lukemelia @achambers if you have a chance to look at this

jrowlingson commented 6 years ago

This allows deploying releases using the git-tag-commit generator without creating new a git tag.

@courajs Could you expand a bit on this? I am interested in your deployment workflow.

courajs commented 6 years ago

Without this, ember deploy fails if the current commit isn't tagged. With it, as long as an ancestor commit is tagged, it will simply append the commit sha to the most recent tag name, and allow the deploy:

-   timestamp           | revision
- =================================
- > 2018/03/30 19:16:11 | v0.1.0+a96d264a
-   2018/03/30 19:03:41 | v0.1.0+e3f28123
-   2018/03/30 15:32:09 | v0.1.0+e6d393e4
-   2018/03/30 15:30:14 | v0.1.0+3a75100f
-   2018/03/30 13:41:23 | v0.1.0+7b5e9631

While you might not do this for production, it's useful when your versioning process involves validation in staging before approving a version bump.

lukemelia commented 6 years ago

Thanks @courajs. I'm +1 on this. @achambers we should make sure that the git revision data plugin gets a similar bump.

achambers commented 6 years ago

@lukemelia said:

Thanks @courajs. I'm +1 on this. @achambers we should make sure that the git revision data plugin gets a similar bump.

Roger that.

ludalex commented 5 years ago

Any plans on merging this?

demee commented 5 years ago

LGTM!

lukemelia commented 3 years ago

I know it's been a while. My apologies. @courajs: if you (or anyone else) wants to take initiative to review this and resolve the conflicts, I'll get it merged.

courajs commented 2 years ago

@lukemelia Conflicts are resolved! Tests are passing and it looks like not too much else has changed in the add-on, so I think this is probably still a good patch?