search

ember-cli-deploy / ember-cli-deploy-revision-data

An ember-cli-plugin to create a unique revision key for the build
MIT License
21 stars 58 forks source link

Allow custom commit hash length when constructing revisionKey #71

Closed HeroicEric closed 3 years ago

HeroicEric commented 5 years ago

What Changed & Why

This allows the length of the commit hash that is used to construct the revisionKey be configured. This applies to the git-commit, git-tag-commit, and version-commit data generator types.

Example usage:

ENV['revision-data'] = {
  type: 'git-commit',
  commitHashLength: 40
}

This example would cause the entire commit hash to be used as the revisionKey.

Related issues

Fixes https://github.com/ember-cli-deploy/ember-cli-deploy-revision-data/issues/22

PR Checklist

People

@bockit

atonse commented 4 years ago

Is there any plan to merge this? We've been bitten by this with regards to the SHAs for SourceMaps not matching.

st-h commented 3 years ago

Is there any hope at all that this PR will get merged one day? Otherwise I am sadly finding myself on a highway to using forks of almost the entire ember-cli-deploy pipeline, because of little inconsistencies like this one.

Any thing I can do to help getting this merged?

lukemelia commented 3 years ago

Yes, let's get it merged. I will work on this later today.

lukemelia commented 3 years ago

@st-h and anyone else who would like to help: I've released https://github.com/ember-cli-deploy/ember-cli-deploy-revision-data/releases/tag/v2.0.0-beta.0. I would like a few people to test it before I make it 2.0.0 final.

st-h commented 3 years ago

Awesome. Thanks so much. Will report back.