Fix setting of credentials via plugin config

ember-cli-deploy / ember-cli-deploy-s3

An ember-cli-deploy plugin to upload to s3

MIT License

53 stars 82 forks source link

Fix setting of credentials via plugin config #187

Closed owen-c closed 7 months ago

owen-c commented 7 months ago

I think AWS SDK v3 migration is broken, there may be other things that were missed. The credential setting definitely doesn't work.

gorner commented 7 months ago

@owen-c Apologies, for #186 I just used Amazon's codemod. Unfortunately I have no reference point other than the addon's own tests, and the app / config I use which seemed to work fine with those changes.

Just tested your changes with my app and they seem to be fine, hopefully @lukemelia can approve and cut a new release soon.

lukemelia commented 7 months ago

Released as 4.0.3. Thanks @owen-c and @gorner