search

ember-cli-deploy / ember-cli-deploy-slack

An ember-cli-deploy plugin for sending messages to Slack
MIT License
21 stars 16 forks source link

Update ember-cli #20

Closed LevelbossMike closed 6 years ago

LevelbossMike commented 6 years ago

What Changed & Why

After merging https://github.com/ember-cli-deploy/ember-cli-deploy-slack/pull/19 I ran tests locally and yarn install failed on my because of the node engine specified in package.json (I'm using the 8.x LTS release of node). I upgraded the engines section to reflect what ember-cli currently specifies as valid node-engines. I also updated the ember-cli development dependency as the old version wasn't happy with the updated package.json's engines-section now.

People

Could you please have a look @lukemelia ?

lukemelia commented 6 years ago

Seems fine to me @LevelbossMike