search

ember-cli / babel-plugin-htmlbars-inline-precompile

Babel plugin to replace tagged template strings with precompiled HTMLBars templates
9 stars 21 forks source link

Support 'ember-cli-htmlbars' import by default #293

Open izelnakri opened 4 years ago

izelnakri commented 4 years ago

This PR adds a performant transpiler support for import { hbs } from 'ember-cli-htmlbars.

Extensive tests are also provided/adjusted for this behavior.

The reasoning behind this PR is described here: https://github.com/ember-cli/babel-plugin-htmlbars-inline-precompile/issues/292

rwjblue commented 4 years ago

This PR adds a performant transpiler support for import { hbs } from 'ember-cli-htmlbars.

What does this mean? This PR adds support for transpiling import { hbs } from 'ember-cli-htmlbars' by default but it doesn't change anything regarding performance.

izelnakri commented 3 years ago

What does this mean? This PR adds support for transpiling import { hbs } from 'ember-cli-htmlbars' by default but it doesn't change anything regarding performance.

Yes, sorry for the wording. I meant the new change wont degrade the performance much since it adds a single if check.

izelnakri commented 3 years ago

@rwjblue thanks for your reviews! Is there anything else blocking this PR? I would like to get it merged otherwise.