search

ember-cli / broccoli-asset-rev

Broccoli plugin to add fingerprint checksums and CDN URLs to your assets
MIT License
86 stars 83 forks source link

Correctly generates rails 4 manifest #13

Closed danmcclain closed 10 years ago

danmcclain commented 10 years ago

Heroku expects a hash in the filename, Heroku will try to precomile the assets, and this causes bad assets to be used

rwjblue commented 10 years ago

Should it write to both paths?

danmcclain commented 10 years ago

No, heroku completely ignores it otherwise, rails generates it with the MD5 hash

rwjblue commented 10 years ago

generateRailsManifest infers Rails, NOT Heroku. I find the actual manifest in a consistent location to be useful also.

rwjblue commented 10 years ago

I just re-read what you said, and it seems that Rails itself generates this with an MD5 in the filename (I didn't realize that), so you are right to only generate a single file in the fashion that Rails expects it.

Sorry for the extra noise....

danmcclain commented 10 years ago

Good point, but rails explicitly says it will be called manifest-md5hash.json: http://guides.rubyonrails.org/asset_pipeline.html#precompiling-assets

danmcclain commented 10 years ago

@rjackson You're ALLLL noise :metal:

rickharrison commented 10 years ago

I'm not a rails user so @rjackson can you sign off on this if its good to merge?

rwjblue commented 10 years ago

:+1:

rickharrison commented 10 years ago

Published as 0.0.16

danmcclain commented 10 years ago

Awesome, thanks!