search

ember-cli / broccoli-asset-rev

Broccoli plugin to add fingerprint checksums and CDN URLs to your assets
MIT License
86 stars 83 forks source link

Just doesn't work on ember-cli #18

Closed James1x0 closed 9 years ago

James1x0 commented 10 years ago

See stefanpenner/ember-cli#1334

rickharrison commented 10 years ago

Please provide a sample project

James1x0 commented 10 years ago

@rickharrison: I'll reference it here as well. James1x0/asset-rev-issue#1

James1x0 commented 10 years ago

@rickharrison: Project updated to 0.0.40 and README.md now shows steps to reproduce issue. Hope this helps. I would think that this issue is because broccoli-less-single is dealing with the tree after broccoli-asset-rev.

jeffhertzler commented 10 years ago

I'm experiencing the same issue with file references in scss files. For now, I'm excluding any scss referenced images from being fingerprinted as a workaround.

I am also using ember-cli.

rickharrison commented 10 years ago

I'm sorry I haven't been able to fix this yet. I'm currently swamped with work. If you could try debugging it a little on your own and providing some more information, that would be really helpful.

James1x0 commented 10 years ago

@rickharrison I hear you there. We are working in a development only enviroment on several projects and won't be need a production build for several weeks. If you haven't fixed it by then, I'll work on a PR.

jeffhertzler commented 10 years ago

If I get some free time I'll spend some of it trying to debug this as well.

My app just went into production, but this is a very minor issue with a simple workaround so not that big of a deal for me.

rickharrison commented 10 years ago

OK thanks! :) I'm super booked through the end of August, but I hope to be able to fix it soon after then.

James1x0 commented 10 years ago

@rickharrison Would you like push access on the test repo or would you rather fork to confirm?

rickharrison commented 10 years ago

I will just fork and clone. Thanks though!

outaTiME commented 10 years ago

news ??

James1x0 commented 10 years ago

Updated test repo James1x0/asset-rev-issue to demonstrate issue even with css files. This is also specifically an issue with rickharrison/broccoli-asset-rewrite.

rickharrison commented 10 years ago

Could you please update to 0.2.0 and let me know if this helps your issue at all?

James1x0 commented 10 years ago

:-1: Still doesn't rev assets in source.

digitalbreed commented 9 years ago

I just ran into this with 0.3.0, referenced background-image URL from less file is not updated. Any updates on this issue?

rickharrison commented 9 years ago

I am currently scheduling some time for myself to look into this issue the 2nd week of november while I am on vacation. I hope to get it fixed then.

rickharrison commented 9 years ago

Please update to 1.0.0 and test it out for me. (This should fix your issue). I apologize about the wait, but I hope that everything is perfect now.

digitalbreed commented 9 years ago

Updated to 1.0.0 and removed fingerprint excludes - works nicely! Thanks for taking care of this.

rickharrison commented 9 years ago

Awesome, glad to hear it. I'm going to close for now. @James1x0 - if it doesn't solve your issue, I will re-open.

James1x0 commented 9 years ago

Can't wait to try it out tomorrow. Thanks @rickharrison!