search

ember-cli / broccoli-asset-rev

Broccoli plugin to add fingerprint checksums and CDN URLs to your assets
MIT License
86 stars 83 forks source link

Allow manifest.json to be generated without fingerprint #39

Closed elucid closed 9 years ago

elucid commented 9 years ago

if added to exclude list

elucid commented 9 years ago

See #38 for discussion.

rickharrison commented 9 years ago

Could you please add a test for this?

elucid commented 9 years ago

I tried adding a test but ran into difficulties because the manifest includes mtime for fingerprinted assets. Consequently the content and fingerprinted filename are different each test run.

If you have a suggestion as to how I can work around this please let me know.

rickharrison commented 9 years ago

Hmm, maybe you can just check the filepath and not assert that its contents are the same?

elucid commented 9 years ago

Added a test that only asserts the correct paths exist.

While all tests pass on my machine, the Travis build is failing. Not sure if it's legit (failing with Could not find .travis.yml, using standard configuration.).

rickharrison commented 9 years ago

Apologies about the delay. Could you rebase and then I will merge?

elucid commented 9 years ago

No worries. Rebased.

rickharrison commented 9 years ago

Thanks!