search

ember-cli / broccoli-asset-rev

Broccoli plugin to add fingerprint checksums and CDN URLs to your assets
MIT License
86 stars 83 forks source link

Add `svg` as a default file extension #80

Closed seanpdoyle closed 8 years ago

seanpdoyle commented 8 years ago

Modern browsers now support svg as a valid background-image value.

We should support this out of the box, without additional configuration.

rickharrison commented 8 years ago

The only reason I'm hesitant to add this is because it is a breaking change and will prevent people from getting future bug fixes who have ^2.0.0 in their package.json

seanpdoyle commented 8 years ago

I agree, it would certainly require at least a minor version bump, but in what way would previous behavior be "broken".

.svg files were ignored / unaffected in previous versions, right?

rickharrison commented 8 years ago

Well someone could explicitly not want svg's to be fingerprinted so I would consider this a major breaking change.

seanpdoyle commented 8 years ago

@rickharrison good point.

Is a major version bump anywhere on the horizon, or is this a bonafide Bad Idea :tm: ?

rickharrison commented 8 years ago

I think it might be a good idea to save this for the next major version. I do have ideas for an internal refactoring to split some things out. I don't have an immediate timeline for that, but its something I'd like to do in the near future.

buschtoens commented 8 years ago

Relevant: #88

seanpdoyle commented 8 years ago

Closing in favor of #88.