search

ember-cli / broccoli-asset-rev

Broccoli plugin to add fingerprint checksums and CDN URLs to your assets
MIT License
87 stars 84 forks source link

Add support for excluding globs instead of only filenames #82

Closed ohcibi closed 8 years ago

rickharrison commented 8 years ago

Can you please rebase this into one commit.

ohcibi commented 8 years ago

Done

rickharrison commented 8 years ago

Sorry, but I actually had to revert this change, because it was a breaking change and I didn't realize it. I added a new test. Could you try to get your PR working with this new test?

ohcibi commented 8 years ago

I'll have a look, but one question: the test says "it accepts a string" but you are passing an array? What is this test actually about? 8-)

rickharrison commented 8 years ago

Sorry, the current format of exclude is an array of strings

ohcibi commented 8 years ago

@rickharrison The test reads like a simple string is also supported (instead of the whole array, e.g. if only one exclude is needed), though. I could PR this as well, if you like 8-)

rickharrison commented 8 years ago

sure go for it.

rickharrison commented 8 years ago

If you just mean renaming the test that is. We don't need to support a simple string. An array of strings is fine.

ohcibi commented 8 years ago

done