search

ember-cli / broccoli-asset-rev

Broccoli plugin to add fingerprint checksums and CDN URLs to your assets
MIT License
86 stars 83 forks source link

Match extensions at path end. #86

Closed nathanhammond closed 8 years ago

nathanhammond commented 8 years ago

The current implementation matches mid-path "extensions." Hoping that you can release a new version after this lands. :)

rickharrison commented 8 years ago

Thanks for submitting this. Could you elaborate a little bit more for me on the bug it is fixing?

nathanhammond commented 8 years ago

I'm creating a proposal for changing the default pattern ember-cli uses when building applications to support interesting new things like ServiceWorkers, HTTP2, and SPDY.

As a result I need to have each asset included individually. That works unless for some reason the path name masquerades as an extension, in which case you get this error:

Build failed.
File: bower_components/loader.js/loader.js
ENOENT: no such file or directory, open '/tmp/fingerprint-output_path-oa046dKV.tmp/bower_components/loader-698e28810a2748f3c53f0a26af030729.js/loader.js'
rickharrison commented 8 years ago

Cool, thanks for the explanation!

rickharrison commented 8 years ago

Published as 2.4.1