search

ember-cli / broccoli-asset-rewrite

Broccoli plugin to rewrite a source tree from an asset map.
MIT License
10 stars 53 forks source link

Upgrade to broccoli-filter 0.2.0 #21

Closed rickharrison closed 9 years ago

stefanpenner commented 9 years ago

LGTM

stefanpenner commented 9 years ago

im curious why we blow away the cache here https://github.com/rickharrison/broccoli-asset-rewrite/blob/filter-upgrade/index.js#L41 rather then setting it up during the construction

rickharrison commented 9 years ago

I originally made that change because I was having issues with the watcher on re-builds.

ziggythehamster commented 9 years ago

For semver, shouldn't this have bumped your minor version number since you went from depending on 0.1.x to 0.2.x? We're on an old version of Ember.js (and Ember CLI, 0.1.15 @stefanpenner), and I believe this package update has caused us trouble.

rickharrison commented 9 years ago

I was under the impression that the upgrade was fully backwards compatible with older versions of broccoli.

ziggythehamster commented 9 years ago

The semver bump of 0.1 to 0.2 in broccoli-filter gives me the impression that they broke something. What, I don't know :). I don't know anything about Broccoli internals, but I do know that I have a node_modules directory that works and a node_modules directory (from an npm install) that does not, and this is one of the very few differences.

rickharrison commented 9 years ago

They changed the abstract api for how you can subclass broccoli-filter. But this plugin was updated to adapt to the new API.

ziggythehamster commented 9 years ago

Ah, well, then I will keep looking. I thought there might have been a link between the update 2 days ago and the fact that I'm now broken. I will keep investigating, but I think I've ruled out this package.

ziggythehamster commented 9 years ago

And now I'm not broken anymore. The three packages that updated for me were this one, ember-inflector, and ember-cli-deploy. ember-cli-deploy switched to depending on Babel in 0.4.3, so I locked at 0.4.2, and ember-inflector needed to be ~1.7.0. I do not know why Babel does not work for my app, but it was a big mess to try and figure this out. Sorry for incorrectly accusing you of not bumping your version properly :)

rickharrison commented 9 years ago

No worries, glad you got it figured out.