Upgrades to broccoli-persistent-filter

codecov-io commented 8 years ago

Current coverage is `100.00%`

Merging #32 into master will not affect coverage as of 9a96f9e

@@            master     #32   diff @@
======================================
  Files            1       1       
  Stmts           83      93    +10
  Branches        19      21     +2
  Methods          0       0       
======================================
+ Hit             83      93    +10
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of 9a96f9e

Powered by Codecov. Updated on successful CI builds.

rickharrison commented 8 years ago

@stefanpenner A test is failing locally for me. Any idea why?

 Error: ENAMETOOLONG: name too long, open '/var/folders/7r/by3dmymj29ggrnd8w7hhx0000000gn/T/async-disk-cache/65abc5ce05f828f069d26299fc0783e5/{"assetMap":{"fonts/OpenSans/Light/OpenSans-Light.eot":"fonts/OpenSans/Light/fingerprinted-OpenSans-Light.eot","fonts/OpenSans/Light/OpenSans-Light.svg":"fonts/OpenSans/Light/fingerprinted-OpenSans-Light.svg","fonts/OpenSans/Light/OpenSans-Light.ttf":"fonts/OpenSans/Light/fingerprinted-OpenSans-Light.ttf","fonts/OpenSans/Light/OpenSans-Light.woff":"fonts/OpenSans/Light/fingerprinted-OpenSans-Light.woff","fonts/OpenSans/Medium/OpenSans-Medium.eot":"fonts/OpenSans/Medium/fingerprinted-OpenSans-Medium.eot","fonts/OpenSans/Medium/OpenSans-Medium.svg":"fonts/OpenSans/Medium/fingerprinted-OpenSans-Medium.svg","fonts/OpenSans/Medium/OpenSans-Medium.ttf":"fonts/OpenSans/Medium/fingerprinted-OpenSans-Medium.ttf","fonts/OpenSans/Medium/OpenSans-Medium.woff":"fonts/OpenSans/Medium/fingerprinted-OpenSans-Medium.woff","foo/bar/widget.js":"blahzorz-1.js","images/sample.png":"images/fingerprinted-sample.png"},"persist":true}bdaa36755eaa31034b16b125341be8a3

stefanpenner commented 8 years ago

@stefanpenner A test is failing locally for me. Any idea why?

looks like you are trying to write the contents of the file as the filename

wagenet commented 6 years ago

@stefanpenner @rickharrison tests are passing but this isn't merged. Any reason why?

gabrielcsapo commented 4 years ago

👋 using persistent filter in broccoli-asset-rewrite will reduce rebuild times. I found this after fixing a similar problem in ember-cli-sass https://github.com/adopted-ember-addons/ember-cli-sass/pull/215. Is there something we can do to get this merged?

rwjblue commented 4 years ago

@gabrielcsapo - Probably best to submit a new PR, I'll try to review/merge.

gabrielcsapo commented 4 years ago

Once I land https://github.com/adopted-ember-addons/ember-cli-sass/pull/215 I will be able to generate a diff between persistent filter and non persistent filter in a larger project.

ember-cli / broccoli-asset-rewrite