search

ember-cli / broccoli-asset-rewrite

Broccoli plugin to rewrite a source tree from an asset map.
MIT License
10 stars 53 forks source link

FIX use of broccoli-persistent-filter -> remove unneeded custom cacheKeyProcessString #33

Closed ghedamat closed 8 years ago

ghedamat commented 8 years ago

this doesn't seem to be needed if not in tests when the same files are used across tests expecting different results

disabling persist does the trick in that case

/cc @stefanpenner

codecov-io commented 8 years ago

Current coverage is 100.00%

Merging #33 into persistent-filter will not affect coverage as of 4c5293b

@@            persistent-filter     #33   diff @@
=================================================
  Files                       1       1       
  Stmts                      93      86     -7
  Branches                   21      20     -1
  Methods                     0       0       
=================================================
- Hit                        93      86     -7
  Partial                     0       0       
  Missed                      0       0

Review entire Coverage Diff as of 4c5293b

Powered by Codecov. Updated on successful CI builds.

rickharrison commented 8 years ago

Would you mind changing the PR to be against master so we can see all the changes at once?

stefanpenner commented 8 years ago

disabling persist does the trick in that case

i think we would ideally want this to be enabled

ghedamat commented 8 years ago

Will do!

Re persist. I'll try to see if we can make it work by changing the files used by those tests. Would that be OK?

rickharrison commented 8 years ago

Go for it. I'm open to any change that will accomplish what ember-cli needs. I'm still not totally familiar with the changes that are required, so I am hopeful for signoff from the ember-cli team.