search

ember-cli / broccoli-asset-rewrite

Broccoli plugin to rewrite a source tree from an asset map.
MIT License
10 stars 53 forks source link

Make a failing regexp work with multiline inputs #48

Open ghost opened 8 years ago

ghost commented 8 years ago

This is probably not helpful but I want to highlight the potential fix here in case anyone else runs into this issue.

https://github.com/rickharrison/broccoli-asset-rewrite/issues/42#issuecomment-253570046

My intuition is that this is actually a bug with broccoli-asset-rev because this code ends up being called with a multiline input.

I don't know much about the background, I only know that this issue is blocking my team and that this fix is working right now :-)

Happy to help try to debug the issue.

ghost commented 8 years ago

Looks like it may be related to https://github.com/ember-cli/ember-cli/issues/6265

codecov-io commented 8 years ago

Current coverage is 100% (diff: 100%)

Merging #48 into master will not change coverage

@@           master   #48   diff @@
===================================
  Files           1     1          
  Lines          85    85          
  Methods        12    12          
  Messages        0     0          
  Branches       20    20          
===================================
  Hits           85    85          
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update 0aa76dc...dbbdcd2

ghost commented 8 years ago

This needs to be tested more before ever merging.