search

ember-cli / broccoli-asset-rewrite

Broccoli plugin to rewrite a source tree from an asset map.
MIT License
10 stars 53 forks source link

Update regex for finding instances of assetPath #64

Closed gojefferson closed 6 years ago

gojefferson commented 6 years ago

This is intended to fix https://github.com/rickharrison/broccoli-asset-rewrite/issues/65

omairvaiyani commented 6 years ago

Thanks @gojefferson this fixed worked for me.

It was breaking on this exact line when confronted with bootstrap's css map.

Would like this patch merged ideally!

gojefferson commented 6 years ago

Thanks @omairvaiyani! Agreed, would be great for it to be merged.

lennyburdette commented 6 years ago

I also just ran into this today. Would you be able to add a test case? Happy to help!

gojefferson commented 6 years ago

@lennyburdette adding a test case would be great. This PR seems like a pretty clear win. Any ideas on what we can do to get it merged?

lennyburdette commented 6 years ago

@gojefferson once there's a test case for this bug, I think you can :wave: at rwjblue either here or in the Ember community slack to get it merged.

gojefferson commented 6 years ago

@lennyburdette I'd love to have your help adding a test case. I'm a bit strapped for time recently, but I could perhaps work on it over the weekend sometime.

g-cassie commented 6 years ago

This issue came up for us today due to some changes in the webpack library. It looks like others are actively working on this PR in the last few hours - is a new release imminent?

gojefferson commented 6 years ago

@g-cassie I don't know. I did ping one of the ember team members in ember-community slack today, so hopefully they'll merge the PR. Seems like a no-brainer to me ¯_(ツ)_/¯