search

ember-cli / broccoli-builder

MIT License
1 stars 10 forks source link

Add line & column to broccoliPayload #19

Closed josemarluedke closed 7 years ago

josemarluedke commented 7 years ago

This adds the line number and column for the broccoliPayload.error.location. Some plugins provide that information such as broccoli-sass-source-maps.

Babel compiler error sends a loc object instead of line & column on the root as broccoli-sass-source-maps. The ember template compiler sends a object called location instead of loc.

This change will help to get more useful information to users on error page and in console.

rwjblue commented 7 years ago

This is great. Only had one question, but that shouldn’t block landing...

josemarluedke commented 7 years ago

Just fixed @rwjblue's comment. I believe this is ready to be merged.