Closed ef4 closed 6 years ago
@courajs: I think this is the underlying cause of your difficulty in getting pleasant-looking build errors.
Seems like either this test is wrong or the change is wrong: https://github.com/ember-cli/broccoli-builder/blob/ed62da3cd5920c1b9c0f312d93a8cc06809f6e74/test/builder_test.js#L123-L145
Looks to me like the test was wrong. It was (accidentally, I think) asserting that SilentErrors get decorated with broccoli instantiation stack, which is kinda the opposite of what SilentErrors are for.
Thanks @ef4 !
❯ np --any-branch
Publish a new version of broccoli-builder (0.18.9)
? Select semver increment or specify new version patch 0.18.10
? Will bump from 0.18.9 to 0.18.10. Continue? Yes
✔ Prerequisite check
✔ Git
✔ Cleanup
✔ Installing dependencies using Yarn
✔ Running tests
✔ Bumping version using Yarn
✔ Publishing package
✔ Pushing tags
broccoli-builder 0.18.10 published 🎉
If a broccoli plugin throws SilentError, we wrap it in a BroccoliBuildError and lose its actual message, resulting in unhelpful output like:
This change gives SilentError priority to be rethrown without being mangled.