search

ember-cli / broccoli-builder

MIT License
1 stars 10 forks source link

Revert "Use __broccoliGetInfo__() to get plugin/node name/label" #28

Closed rwjblue closed 6 years ago

rwjblue commented 6 years ago

Reverts ember-cli/broccoli-builder#27

This is causing the following error:

Error: Minimum builderFeatures required: { persistentOutputFlag: true }
    at SRIHashAssets.Plugin._checkBuilderFeatures (/home/gitlab-runner/builds/12157f87/0/digitalization/personal_network_visualization/node_modules/broccoli-caching-writer/node_modules/broccoli-plugin/index.js:62:11)
    at SRIHashAssets.Plugin.__broccoliGetInfo__ (/home/gitlab-runner/builds/12157f87/0/digitalization/personal_network_visualization/node_modules/broccoli-caching-writer/node_modules/broccoli-plugin/index.js:45:8)
    at getPluginName (/home/gitlab-runner/builds/12157f87/0/digitalization/personal_network_visualization/node_modules/broccoli-builder/lib/builder.js:291:23)
    at new Node (/home/gitlab-runner/builds/12157f87/0/digitalization/personal_network_visualization/node_modules/broccoli-builder/lib/builder.js:260:11)
    at readAndReturnNodeFor (/home/gitlab-runner/builds/12157f87/0/digitalization/personal_network_visualization/node_modules/broccoli-builder/lib/builder.js:112:16)
    at /home/gitlab-runner/builds/12157f87/0/digitalization/personal_network_visualization/node_modules/broccoli-builder/lib/builder.js:52:14
    at tryCatch (/home/gitlab-runner/builds/12157f87/0/digitalization/personal_network_visualization/node_modules/broccoli-builder/node_modules/rsvp/dist/rsvp.js:525:12)
    at invokeCallback (/home/gitlab-runner/builds/12157f87/0/digitalization/personal_network_visualization/node_modules/broccoli-builder/node_modules/rsvp/dist/rsvp.js:538:13)
    at /home/gitlab-runner/builds/12157f87/0/digitalization/personal_network_visualization/node_modules/broccoli-builder/node_modules/rsvp/dist/rsvp.js:606:14
    at flush (/home/gitlab-runner/builds/12157f87/0/digitalization/personal_network_visualization/node_modules/broccoli-builder/node_modules/rsvp/dist/rsvp.js:2415:5)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Reverting for now so that we can investigate more fully...

rwjblue commented 6 years ago

/cc @oligriffiths

oligriffiths commented 6 years ago

Huh. Wonder why this didn’t come up in testing. Will investigate, it was only a nice to have anyway.