search

ember-cli / ember-ajax

Service for making AJAX requests in Ember applications
MIT License
212 stars 87 forks source link

ember-ajax does not work with Ember 3.8 when transpiling to ES5 #431

Closed boris-petrov closed 5 years ago

boris-petrov commented 5 years ago

Original issue in Ember.js.

Babel cannot transpile to ES5 extending from some built-in types which means that extending EmberError won't work any more in ES5 since Ember 3.8 because it is the same as Error.

Turbo87 commented 5 years ago

as mentioned on Discord, the way I would propose to fix this is:

1) update ember-cli-babel to v7 and check if that fixes the test suite 2) update the Node.js compatibility claims in package.json and PR it (see https://github.com/ember-cli/ember-ajax/pull/432) 3) open a PR for 1) which also updates the "Compatibility" section, adding CLI 2.13+ requirement (see https://github.com/ember-cli/ember-ajax/pull/433) 4) get it released as v5.0.0 5) update the app blueprint in Ember CLI 6) get that released as v3.8.1