search

ember-cli / ember-ajax

Service for making AJAX requests in Ember applications
MIT License
212 stars 87 forks source link

Fix deprecated usage of `run.join` #452

Closed boris-petrov closed 3 years ago

boris-petrov commented 3 years ago

Fixes #451.

cc @rwjblue, @Turbo87, @mike-north

boris-petrov commented 3 years ago

Can we get this merged and released please? :)

Turbo87 commented 3 years ago

unfortunately CI failed 😞

would you have time to port the CI pipeline to GitHub Actions?

boris-petrov commented 3 years ago

@Turbo87 - I agree that having a working CI is good but this fix is obviously correct so merging and releasing would be nice. We get lots of warnings in the console which would go away.

There is #453 which is for fixing CI but could we merge this before we resolve the issues with GitHub Actions please?

boris-petrov commented 3 years ago

@Turbo87 - thanks for merging this! Now a new release will be very appreciated! :)

boris-petrov commented 3 years ago

@rwjblue, @Turbo87, @mike-north - ping. :) Can we get a new release, please? :)

boris-petrov commented 3 years ago

@rwjblue, @Turbo87, @mike-north - ping. :) Can we get a new release, please? :)

boris-petrov commented 3 years ago

@rwjblue, @Turbo87, @mike-north - ping. :) Can we get a new release, please? :)

boris-petrov commented 3 years ago

@rwjblue, @Turbo87, @mike-north - ping. :) Can we get a new release, please? :)